Change Enchantment API for data-driven enchantments #3761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation actually diverges from vanilla and replaces all
isPrimaryItemcalls withisAcceptableItemby default, so in theory one could enchant an axe with sharpness inside an enchanting table, which is definitely a bug.This PR fixes that, and now that vanilla clearly delineates "acceptable" and "primary" checks,
EnchantingContextwas (breakingly) reworked. Given how recent the enchantment API is and how much the datafication of enchantments will break enchantment code anyway, I don't think the breakage is a very big deal.Testmod is still very very broken, we might need a DRM argument or something in some places.No DRM needed, as the recommended design is now to work with enchantment tags rather than specific ones inside code.