Fix ClientMessageEvents Injection Points #3778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apple502j
added
bug
apple502j
approved these changes
May 19, 2024
modmuss50
approved these changes
May 19, 2024
modmuss50
pushed a commit
that referenced
this pull request
May 20, 2024
(cherry picked from commit a7dc0e4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the update to 1.20.5, the local variable accesses are changed in
MessageHandler#onGameMessage, so thatGAMEandMODIFY_GAMEwould not fire ifclient.options.getHideMatchedNames()isfalse(which usually does not happen).This PR updates that injection along with the
ClientSendMessageEventsinjection points to useLocalRefinstead to make the code more resilient to updates. This has no behavior or api contract change, only a small bug fix.