Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace redirect in lifecycle events with wrap operation #3887

Merged
merged 2 commits into from
Aug 4, 2024

Conversation

AlphaMode
Copy link
Contributor

Noticed a old redirect while updating porting lib to 1.21. So I thought I might create a quick PR to fix this.

@Dragon-Seeker
Copy link

Seems fine

@AlphaMode
Copy link
Contributor Author

Sugar could also be used here but I figured that would be just as hacky as using locals

@modmuss50
Copy link
Member

I assume there is a reason for making this change? Generally my rule in moving stuff to mixin extras is to only do it when there is actually a need/benefit or when the mixin need changing anyway (Usually during a port).

@AlphaMode
Copy link
Contributor Author

I assume there is a reason for making this change? Generally my rule in moving stuff to mixin extras is to only do it when there is actually a need/benefit or when the mixin need changing anyway (Usually during a port).

I found it because it was causing a conflict in porting lib. I fixed this by just changing the injection point.
Anyway there isn't really not a reason to change this as it would prevent future possible conflicts

@modmuss50 modmuss50 added merge me please Pull requests that are ready to merge small change labels Jul 27, 2024
@modmuss50 modmuss50 merged commit 6c1df36 into FabricMC:1.21 Aug 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me please Pull requests that are ready to merge small change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants