After Damage Event #4051
Merged
After Damage Event #4051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
reviewed
Aug 23, 2024
| * is applied, or after that damage was blocked by a shield. | ||
| * | ||
| * <p>Damage dealt is the damage initially applied to the entity. Damage taken is the amount of damage the entity | ||
| * actually took, after effects such as shields and extra freezing damage are applied. Damage taken does NOT include |
There was a problem hiding this comment.
I wonder if it should be renamed to baseDamageTaken or something else to make it clear its not the final amount of damage?
PR looks good otherwise 👍
There was a problem hiding this comment.
sounds good, pushed change 👍
modmuss50
approved these changes
Aug 26, 2024
modmuss50
pushed a commit
that referenced
this pull request
Aug 26, 2024
* after damage event * add after damage event to testmod * remove amount > 0 check to capture shield blocking * add javadoc * dont fire event if killed * clarify javadoc a bit more * fix checkstyle issue * fix other checkstyle issues lol * rename damageDealt to baseDamageTaken (cherry picked from commit 2122d82)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a server-side only entity event after an entity is damaged. The event is fired after damage is applied, and includes both damage dealt and damage taken. However, damage taken is a bit weird. Its not the final amount of health reduction, but the damage the entity receives just armour / enchantments are applied and after shield,
freeze_hurts_extra_types, and helmet damage reduction. The event is not fired if the damage killed the entity.I'm not sure if the difference between damage dealt and damage taken is clear enough that they should be separate here. Maybe it would be best to only supply the damage taken? These two numbers are both supplied to the
player_hurt_entityandentity_hurt_playeradvancement criteria, so I thought their inclusion here made sense. However, as this is a fairly easy change to make I thought I would just open this now to see what people think.