Add support for Item-containing Items #4083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BasiqueEvangelist
force-pushed
the
items-in-items
branch
2 times, most recently
from
5f3d7c8
to
2889334
Compare
|
The PR this depends on has been merged. |
Technici4n
suggested changes
Oct 7, 2024
fabric-transfer-api-v1/src/main/java/net/fabricmc/fabric/api/transfer/v1/item/ItemStorage.java
Show resolved
Hide resolved
...nsfer-api-v1/src/main/java/net/fabricmc/fabric/impl/transfer/item/BundleContentsStorage.java
Show resolved
Hide resolved
...nsfer-api-v1/src/main/java/net/fabricmc/fabric/impl/transfer/item/BundleContentsStorage.java
Outdated
Show resolved
Hide resolved
...nsfer-api-v1/src/main/java/net/fabricmc/fabric/impl/transfer/item/BundleContentsStorage.java
Show resolved
Hide resolved
...nsfer-api-v1/src/main/java/net/fabricmc/fabric/impl/transfer/item/BundleContentsStorage.java
Show resolved
Hide resolved
...r-api-v1/src/main/java/net/fabricmc/fabric/impl/transfer/item/ContainerComponentStorage.java
Outdated
Show resolved
Hide resolved
...r-api-v1/src/main/java/net/fabricmc/fabric/impl/transfer/item/ContainerComponentStorage.java
Show resolved
Hide resolved
...r-api-v1/src/main/java/net/fabricmc/fabric/impl/transfer/item/ContainerComponentStorage.java
Outdated
Show resolved
Hide resolved
...pi-v1/src/testmod/java/net/fabricmc/fabric/test/transfer/ingame/TransferTestInitializer.java
Show resolved
Hide resolved
...pi-v1/src/testmod/java/net/fabricmc/fabric/test/transfer/ingame/TransferTestInitializer.java
Show resolved
Hide resolved
…transfer/item/ContainerComponentStorage.java Co-authored-by: Technici4n <13494793+Technici4n@users.noreply.github.com>
BasiqueEvangelist
force-pushed
the
items-in-items
branch
from
2f04b44
to
49c8d1e
Compare
apple502j
suggested changes
Oct 8, 2024
fabric-transfer-api-v1/src/main/java/net/fabricmc/fabric/api/transfer/v1/item/ItemStorage.java
Outdated
Show resolved
Hide resolved
...nsfer-api-v1/src/main/java/net/fabricmc/fabric/impl/transfer/item/BundleContentsStorage.java
Outdated
Show resolved
Hide resolved
...nsfer-api-v1/src/main/java/net/fabricmc/fabric/impl/transfer/item/BundleContentsStorage.java
Outdated
Show resolved
Hide resolved
...nsfer-api-v1/src/main/java/net/fabricmc/fabric/impl/transfer/item/BundleContentsStorage.java
Outdated
Show resolved
Hide resolved
Well, the ContainerComponentStorage impl could probably be opened up for mods to use, considering it's suitably generic. I made it internal for now because I didn't want to have to figure out how to properly expose it. |
|
Yes it's fine to keep it internal like that. At this point just having |
apple502j
approved these changes
Oct 11, 2024
modmuss50
approved these changes
Oct 11, 2024
modmuss50
added
last call
modmuss50
pushed a commit
that referenced
this pull request
Oct 15, 2024
* first steps toward container item support * add bundle support * Update fabric-transfer-api-v1/src/main/java/net/fabricmc/fabric/impl/transfer/item/ContainerComponentStorage.java Co-authored-by: Technici4n <13494793+Technici4n@users.noreply.github.com> * address reviews + TIL ContainerItemContext#find exists * address reviews of bundle code --------- Co-authored-by: Technici4n <13494793+Technici4n@users.noreply.github.com> (cherry picked from commit 4054068)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently draft, sinceonly Shulker Boxes are supportedthe PR this depends on hasn't been merged.Based on #4082, until that is merged changes from that PR will show up in the diff and commit log.Actual diff