Remove deprecated BlockRenderLayerMap#putItem*
#4090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OroArmor
approved these changes
Sep 13, 2024
apple502j
approved these changes
Sep 13, 2024
modmuss50
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods turn the item into a block using
Block.getBlockFromItem(Item)and use that block for actual registration. Thus, theputIem*methods are unnecessary and in my opinion are a confusing API. The comment that says "in previous snapshots Items had their own map for render layers" also makes me think that these methods were added and should have been removed in the same snapshot cycle, but were not.