Fix includeData in pick events #4232
Open
+10
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apple502j
added
bug
|
Is the include data flag set only for creative players by the client? If any player can request data to be included, I think the current behavior works well, just like how block interaction events are invoked for spectators. The parameter name and documentation could be changed to make the onus of authorization checking a bit more clear, though. |
|
Spectators can interact with chests; vanilla |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the game mode check for
includeDatawas omitted. Vanilla only allowsincludeDataif the player is in Creative mode. Only affects the snapshots.Also fixes several javadoc issues.