Fix block outline rendering #4286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move outline event invoker to before either normal or high contrast outlines are rendered - Remove outline layer reset, fixing high contrast outline being rendered with wrong layer - Pass translucent parameter to BEFORE_BLOCK_OUTLINE event - Remove deprecated BlockOutlineContext#vertexConsumer
PepperCode1
added
bug
modmuss50
requested changes
Dec 9, 2024
...ering-v1/src/client/java/net/fabricmc/fabric/api/client/rendering/v1/WorldRenderContext.java
Show resolved
Hide resolved
modmuss50
reviewed
Dec 9, 2024
...dering-v1/src/client/java/net/fabricmc/fabric/api/client/rendering/v1/WorldRenderEvents.java
Outdated
Show resolved
Hide resolved
|
Was about to say I think it's fine to break this API now - however turns out the API is much more frequently used than I thought. |
modmuss50
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WorldRenderContext#translucentBlockOutline, usable in theBEFORE_BLOCK_OUTLINEandBLOCK_OUTLINEeventsFixes #4285.