Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE in WaterPotionStorage#isWaterPotion #4313

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

Technici4n
Copy link
Member

@Technici4n Technici4n commented Dec 19, 2024

Fixes #4311. Probably needs to be backported all the way back to 1.20.4.

@Technici4n Technici4n requested a review from a team December 23, 2024 10:33
@modmuss50 modmuss50 added bug Something isn't working priority:high High priority PRs that need review and work now. Review these first. merge me please Pull requests that are ready to merge labels Dec 23, 2024
@modmuss50
Copy link
Member

Im going to release this for 1.21.4 now, and will back port for other versions later.

@modmuss50 modmuss50 merged commit efa825c into FabricMC:1.21.4 Dec 24, 2024
4 checks passed
modmuss50 pushed a commit that referenced this pull request Dec 30, 2024
* Fix NPE in WaterPotionStorage#isWaterPotion

* Make checkstyle happy

(cherry picked from commit efa825c)
modmuss50 pushed a commit that referenced this pull request Dec 30, 2024
* Fix NPE in WaterPotionStorage#isWaterPotion

* Make checkstyle happy

(cherry picked from commit efa825c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working merge me please Pull requests that are ready to merge priority:high High priority PRs that need review and work now. Review these first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transfer API WaterPotionStorage#isWaterPotion() needs to check for empty components
2 participants