Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some AbstractFurnaceScreenHandler constants. #3676

Closed
wants to merge 2 commits into from
Closed

Some AbstractFurnaceScreenHandler constants. #3676

wants to merge 2 commits into from

Conversation

gudenau
Copy link
Contributor

@gudenau gudenau commented Sep 19, 2023

I left field_30744 and field_30745 alone because they are the same constants, but they appear to be something like PLAYER_MAIN_INVENTORY_END.

@modmuss50 modmuss50 added the update-base Add this label to a pull request to automatically change the target branch to the default branch. label Oct 10, 2023
@github-actions github-actions bot changed the base branch from 1.20.2-rc2 to 23w40a October 10, 2023 20:03
@github-actions
Copy link
Contributor

🚀 Target branch has been updated to 23w40a

@github-actions github-actions bot added snapshot A PR that targets a snapshot version of Minecraft and removed update-base Add this label to a pull request to automatically change the target branch to the default branch. labels Oct 10, 2023
modmuss50
modmuss50 reviewed Oct 11, 2023
View reviewed changes
mappings/net/minecraft/screen/AbstractFurnaceScreenHandler.mapping
Comment on lines +5 to +11
FIELD field_30738 BURN_TIME_PROPERTY_INDEX I
FIELD field_30739 FUEL_TIME_PROPERTY_INDEX I
FIELD field_30740 COOK_TIME_PROPERTY_INDEX I
FIELD field_30741 COOK_TIME_TOTAL_PROPERTY_INDEX I
FIELD field_30742 PROPERTY_COUNT I
FIELD field_30743 INVENTORY_SIZE I
FIELD field_30746 PLAYER_INVENTORY_END I
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these are likely to be the slot id, im not sure these names are correct. We generally dont map stuff like this unless we are 100% sure about it, in this case I dont think you can be sure.

@gudenau gudenau closed this Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modmuss50 modmuss50 modmuss50 left review comments

Assignees
No one assigned
Labels
snapshot A PR that targets a snapshot version of Minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gudenau @modmuss50