-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename tickDelta to tickProgress #4094
base: 25w04a
Are you sure you want to change the base?
Conversation
bf85889
to
02cf0a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Good catch, my replace-all command was case-sensitive 😅 |
I'd also check whether parameters have been shortened from |
I've checked what I could and replaced it. Note that in I recommend that the maintainers review this PR by checking each commit separately to not get lost too much |
e0c4c95
to
c4d1635
Compare
This PR replaces all mentions of 'tickDelta' with 'tickProgress'. For an explanation of 'tickDelta', see FabricMC/fabric-docs#173
I hesitated to make this pull request for a while. I think the name 'tickProgress' is not as good as it can be. Parchment uses 'partialTick', but some Fabricord members argued that it is too vague and it should be named 'fractionalTick' instead
I went with 'tickProgress' because it lines up with its main chunk of usages - MathHelper#lerp (
MathHelper.lerp(tickProgress, prevPos, pos)
sounds more obvious thanMathHelper.lerp(partialTick, prevPos, pos)
)If you have any suggestions for a better name, please don't be afraid to leave a comment