EntitySize -> EntityDimensions

[Sollace]

Changes for the issue at #715

[liach]

please change all getter methods to getDimensions instead of getSize; same for fields/method params

[liach]

also consider renaming constant to fixed

[ChloeDawn]

The parameter names for the static constructors are incorrect. They should be width and height not x and z.

[ChloeDawn]

fieldEnderDragonPart#partSize -> EnderDragonPart#dimensions
fieldEntity#size -> Entity#dimensions
fieldEntityType#size -> EntityType#dimensions
fieldEntityType$Builder#size -> EntityType$Builder#dimensions
fieldLivingEntity.SLEEPING_SIZE -> LivingEntity.SLEEPING_DIMENSIONS
fieldPlayerEntity.SIZES -> PlayerEntity.POSE_DIMENSIONS
fieldPlayerEntity.STANDING_SIZE -> PlayerEntity.STANDING_DIMENSIONS
methodEntity#getSize(EntityPose) -> Entity#getDimensions(EntityPose)
methodEntity#refreshSize -> Entity#refreshDimensions
methodEntityType#getDefaultSize -> EntityType#getDefaultDimensions
paramEntity#getEyeHeight@size -> Entity#getEyeHeight@dimensions
paramEntityType.<init>@size -> EntityType.<init>@dimensions
paramLivingEntity#getActiveEyeHeight@size -> LivingEntity#getActiveEyeHeight@dimensions

[ChloeDawn]

Migration required for Fabric's EntityTypeBuilder:
fieldsize -> dimensions
methodsize -> dimensions
paramsize@size -> dimensions

[kashike]

I'm not a fan of this name change - it will cause confusion with world dimensions.

[ChloeDawn]

I agree, but either way, I do not want a partial migration. All or nothing. Personally, I would call this data class EntityShape as it implies the width and height, and separates it away from the concept of dimensions that the game already has.

[liach]

i originally opposed this change, but i find that it will be clear if we call this one dimensions (with the s suffix) instead of dimension.

[Sollace]

@liach @kashike Again, I remind everyone that it is Dimensions with an S.

@liach I did consider doing name changes for all the getters as well, however I don't believe it's neccessary to have it use the same terminology as the class name. It's clear enough to see that getSize() returns a some form of Dimensions. It also avoids confusion with a method like getDimension().

[Sollace]

@liach I thought people specifically didn't want that changed to fixed? (which is why it was left out of the PR)
@InsomniaKitten (pinged wrong person)

I believe constant is fine too, representing an immutable size. Imo fixed doesn't really imply that well.

[kashike]

@Sollace I am well aware it has an s, my statement is not changing.

[Sollace]

I was also thinking about world dimensions, and what's stopping us from calling them Levels or LevelTypes? Minecraft has used that term in the past when referring to the overworld, so I don't see why they wouldn't still have it internally.

[liach]

how about EntityExtent?

[liach]

EntityMeasure would be clear and non-confusing.

See defintion 4 at https://www.dictionary.com/browse/measures (noun section)

the extent, dimensions, quantity, etc., of something, ascertained especially by comparison with a standard:
to take the measure of a thing.

This covers "dimensions" "extent" in a sense while it won't be confusing as "extent" or "dimension" (both has been used in spongeapi to refer to world stuff)

@kashike @InsomniaKitten @Prospector wanna hear your opinions.

[copygirl]

I was also thinking about world dimensions, and what's stopping us from calling them Levels or LevelTypes?

The term is already standard in the entire community.
Very early on we had a discussion on this. It didn't really lead anywhere, but see #89.

---

That said, I'm split on the change.
Pro: toString clearly mentioning the actual name of the class.
Con: It kind of clashes with Dimension, for auto-complete suggestions and such.

I also don't necessarily see Size as a scalar value. It is often used in a 2D context to describe an element's width and height. And I don't think we should introduce another name that is different from Mojang's name.

[Sollace]

EntityMeasure would be clear and non-confusing.

@liach Even though you didn't ask for it, I don't know if I like using EntityMeasure. What is it a measure of? Volume? Age? Does it specify width/height in meters, or centimeters?

Measure to me is something of standard, fixed, size or dimensions that you use to measure something. Like how a meter stick is a measure of length.

[liach]

this way, dimensions is a plain scalar as well. i'd say stay with size; we should not be trolled by mojang for such a tostring statement after all.

[NeunEinser]

this way, dimensions is a plain scalar as well.

Not sure what you are referring to. You can measure in m² (or m³), too, which to my understanding is the case when you measure dimensions since you are measuring all dimensions of the object.

I think Wikitonary's definition pretty much nails it and describes perfectly what this class is. (definition of a single dimension, not the plural form)

A measure of spatial extent in a particular direction, such as height, width or breadth, or depth.

[Runemoro]

To me a size is the overall size of something. I wouldn't expect a class named EntitySize to give both a width and height.

@kashike Currently Entity.getSize (which returns its dimensions, not size!) conflicts with SlimeEntity.getSlimeSize (which correctly returns a single integer size!).

[asiekierka]

I say EntityDimensions.