Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FishingBobberEntity Mappings #820

Merged
merged 3 commits into from
Oct 9, 2019
Merged

FishingBobberEntity Mappings #820

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ef7b40
FishingBobberEntity complete
juliand665 Aug 18, 2019
193a416
following boolean field naming conventions
juliand665 Aug 18, 2019
a7fc7dc
naming improvements
juliand665 Aug 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions mappings/net/minecraft/entity/projectile/FishingBobberEntity.mapping
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,17 @@
CLASS net/minecraft/class_1536 net/minecraft/entity/projectile/FishingBobberEntity
CLASS class_1537 State
FIELD field_7165 hookedEntity Lnet/minecraft/class_1297;
FIELD field_7168 luckOfTheSeaLevel I
FIELD field_7166 selfHitTimer I
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is self really necessary here? Could we simply this to hitTimer instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While selfHitTimer > 0, the bobber won't attach to the entity holding its fishing rod. I feel like the name selfHitTimer conveys that information pretty well.

FIELD field_7167 removalTimer I
FIELD field_7168 lureLevel I
FIELD field_7169 fishAngleDegrees F
juliand665 marked this conversation as resolved.
Show resolved Hide resolved
FIELD field_7170 HOOK_ENTITY_ID Lnet/minecraft/class_2940;
FIELD field_7171 lureLevel I
FIELD field_7171 luckOfTheSeaLevel I
FIELD field_7172 fishTravelCountdown I
FIELD field_7173 hookCountdown I
FIELD field_7174 waitCountdown I
FIELD field_7175 state Lnet/minecraft/class_1536$class_1537;
FIELD field_7176 hasHitNonEntity Z
juliand665 marked this conversation as resolved.
Show resolved Hide resolved
FIELD field_7177 owner Lnet/minecraft/class_1657;
METHOD <init> (Lnet/minecraft/class_1657;Lnet/minecraft/class_1937;II)V
ARG 1 thrower
Expand All @@ -23,4 +30,12 @@ CLASS net/minecraft/class_1536 net/minecraft/entity/projectile/FishingBobberEnti
ARG 3 lureLevel
ARG 4 luckOfTheSeaLevel
METHOD method_6947 getOwner ()Lnet/minecraft/class_1657;
METHOD method_6949 tickFishingLogic (Lnet/minecraft/class_2338;)V
juliand665 marked this conversation as resolved.
Show resolved Hide resolved
ARG 1 pos
METHOD method_6951 updateHookedEntityId ()V
METHOD method_6952 smoothenMovement ()V
METHOD method_6954 pullHookedEntity ()V
METHOD method_6957 use (Lnet/minecraft/class_1799;)I
ARG 1 usedItem
METHOD method_6958 checkForCollision ()V
METHOD method_6959 checkRemoval ()Z
juliand665 marked this conversation as resolved.
Show resolved Hide resolved