DES-20 #9
Merged
DES-20 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a significant change as I needed to change the project organization and dependencies for testing to allow for better refactoring opportunities. You will likely need to run `<path to mvn.cmd> dependency:purge-local-repository in the project directory in order for intellisense to trigger without a build. All tests currently pass except for the ExceptionLinterTest, which is currently serving as a testbed for the new AnalyzerFixture testing architecture.
There are some more refactorings I plan on doing separate from any listed issues in the JIRA, mainly testing the @ParameterizedTest feature of JUnit I found while reading documentation to reduce code.
…Format This is actually nice: the number of tests don't change but the lines of test code have shrunk by ~130 lines!
FaceFTW
force-pushed
the
DES-20
branch
3 times, most recently
from
6a6fdfc
to
b1f7861
Compare
|
Looks good to me. Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a long-Running PR, DO NOT CLOSE YET