This repository has been archived by the owner on May 23, 2024. It is now read-only.
Expose xtask as a binary entry and streamline "target/architecture" input #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinjlowm
changed the title
simonvandel
suggested changes
Jan 6, 2023
| use anyhow::Result; | ||
| use xshell::pushd; | ||
|
|
||
| fn main() -> Result<()> { |
There was a problem hiding this comment.
I would rename the file to src/xtask.rs.
Then you need to add a [bin] target to cargo.toml
| } | ||
|
|
||
| fn project_root() -> PathBuf { | ||
| Path::new( |
There was a problem hiding this comment.
We cannot assume that xtask is invoked via a cargo alias anymore, so perhaps it's better to require the user to take the cargo workspace path in?
|
With our use of Nix, and a potential mono-repo-fication in-progress, I think this PR is redundant. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves our xtask implementation from cloud-services and cloud-ingress such that we can use it EVERYWHERE! 🥳
rust-lang/cargo#1982 🤔