Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Allow DynamoDB consumers to bring their own config #82

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

martinjlowm
Copy link
Member

For data-rollup we heavily rely on DLQ behavior and we don't want waste retry attempts within the same Lambda invocation. Now, the consumer can provide their own config and disable retry attempts.

@martinjlowm
Copy link
Member Author

meh problems with caching the value... perhaps we can do this smarter... creating a client manually for now.

@simonvandel
Copy link
Collaborator

In what situations do we not want to have the default retry-behaviour of the aws-sdk?
The errors they retry are transient errors, so for instance a ObjectNotFound error should not be retried by them. IMO this disabling the retry-logic will be a step back. Then spurious network errors will lead to messages in DLQ, rather than just trying the operation again which will then succeed.

@martinjlowm martinjlowm marked this pull request as draft November 17, 2023 09:09
@martinjlowm
Copy link
Member Author

Parking this for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants