Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rzCOBS encoding #15

Merged
merged 6 commits into from
Jun 25, 2021
Merged

Use rzCOBS encoding #15

merged 6 commits into from
Jun 25, 2021

Conversation

eupn
Copy link
Contributor

@eupn eupn commented Jun 18, 2021

Obvious in a hindsight, but works perfectly fine with a 0xFF as a sentinel byte.

Closes #12.
Related defmt-persist-print PR: https://github.com/eupn/defmt-persist-print/1.

P.S.: tested in hardware, works fine!

@MathiasKoch
Copy link
Member

I somehow missed this PR.. Think i accidentally unwatched my own repo, sorry about that!

But AWESOME work! I think you need to disable the std feature on rzCOBS?

@eupn
Copy link
Contributor Author

eupn commented Jun 25, 2021

@MathiasKoch std is used for decoding during testing (see dev-dependencies section). Not sure why it's being used during the build. On the other hand, it's working in my firmware when defmt-persist crate is used as a dependency.

@MathiasKoch
Copy link
Member

Hmm.. Not sure why the tests fail then?

@MathiasKoch
Copy link
Member

@eupn Can you merge master into this?

@eupn
Copy link
Contributor Author

eupn commented Jun 25, 2021

@MathiasKoch rebased on the latest master.

@MathiasKoch
Copy link
Member

Hmm.. still seems to fail?

@eupn
Copy link
Contributor Author

eupn commented Jun 25, 2021

@MathiasKoch, I think this rust-lang/cargo#1596 is related to this issue with CI builds.

P.S.: people have similar issues here rafalh/rust-fatfs#39 with std dev-dependency pulled in when building for no_std target.

@eupn
Copy link
Contributor Author

eupn commented Jun 25, 2021

@MathiasKoch seems that feature resolver v2 fixes the issue.

@MathiasKoch
Copy link
Member

Ahh perfect! Great catch 👍

@MathiasKoch MathiasKoch merged commit da32db6 into FactbirdHQ:master Jun 25, 2021
@eupn eupn deleted the rzcobs branch June 26, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve storage utilization using rzCOBS
2 participants