-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Django 4.1 #1068
Conversation
54007c9
to
642a48c
Compare
docs/changelog.rst
Outdated
@@ -19,6 +19,7 @@ ChangeLog | |||
*Removed:* | |||
|
|||
- Drop support for Django 4.0 | |||
- Drop support for Django 4.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rephrase this as "Stop testing for Django 4.1 compatibility".
We're not actively dropping that support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We’re removing the PyPI marker and no longer care for compatibility with Django 4.1, so I think drop support is accurate, although we’re not removing django 4.1 specific code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, when I read the changelog of a third-party package and see there "Drop support for Python 2", I understand that the code is likely to break with Python 2, for instance :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code could break for Django 4.1 and we wouldn’t know, or care. But enough discussion on this topic, I updated to a more precise phrasing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I see the "Drop support for X"
in other projects I tend to view it as "use at your own risk", it may or may not work... Just my $0.02.
What you've got is fine too.
642a48c
to
2c00c39
Compare
Upstream dropped support in January 2024.
No description provided.