98 voting pallet #107

letodunc · 2022-08-16T05:11:18Z

Implemented functions to manage voting through the collective and democracy pallet for the House Council vote session and Investors vote session

* Runtime update Update to polkadot-v0.9.26 * Token symbol and pallet-uniques Added the pallet-uniques to the runtime, and changed the token Symbol to USD * Benchmarking fixed Co-authored-by: ndkazu <ndongmefane@gmail.com> Co-authored-by: Kazunobu Ndong <33208377+ndkazu@users.noreply.github.com>

* Runtime update Update to polkadot-v0.9.26 * Token symbol and pallet-uniques Added the pallet-uniques to the runtime, and changed the token Symbol to USD * Benchmarking fixed * refresh FS repo (#101) * update readme and badges * delete diagram * add w3f badge and adjust readme * adjust size and position * remove unused files * adjusted the readme some more * add w3f badge back * changed from docker hub to ghcr registry * small change to the DockerFile * 102 automatization tasks (#103) * added a script to add a new pallet from a pallet template and configure the runtime Cargo.toml and lib.rs * added a script to update polkadot lib in .toml files for the node, runtime, pallets and pallet template Co-authored-by: ndkazu <ndongmefane@gmail.com> Co-authored-by: Kazunobu Ndong <33208377+ndkazu@users.noreply.github.com> Co-authored-by: Ilhan <29432367+ilhanu@users.noreply.github.com> Co-authored-by: “ilhanu” <ilhanunlu@gmail.com>

…onfig

…ir-squares into 98-voting-pallet

codecov-commenter · 2022-08-16T06:49:34Z

Codecov Report

Merging #107 (cef7e62) into main (9bcff90) will decrease coverage by 7.86%.
The diff coverage is 2.83%.

@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   60.34%   52.48%   -7.87%     
==========================================
  Files          22       27       +5     
  Lines        1339     1551     +212     
==========================================
+ Hits          808      814       +6     
- Misses        531      737     +206

Impacted Files	Coverage Δ
node/src/chain_spec.rs	`0.00% <0.00%> (ø)`
pallets/voting/src/lib.rs	`0.00% <0.00%> (ø)`
pallets/voting/src/structs.rs	`0.00% <0.00%> (ø)`
pallets/voting/src/weights.rs	`0.00% <0.00%> (ø)`
runtime/src/lib.rs	`2.77% <0.00%> (-0.30%)`	⬇️
pallets/voting/src/mock.rs	`60.00% <60.00%> (ø)`
pallets/voting/src/tests.rs	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ndkazu

Did a global review focusing on lib.rs, but I think we need to complete the testing part in order to do a better review and do the merge in main

pallets/voting/src/lib.rs

ndkazu · 2022-08-16T08:02:34Z

pallets/voting/src/lib.rs

+			// Check that the extrinsic was signed and get the signer
+			let who = ensure_signed(origin)?;
+
+			// Check that the account has the investor role


The role (correctly defined in the code) is Seller, instead of investor

ndkazu · 2022-08-16T08:21:41Z

pallets/voting/src/structs.rs

+};
+
+use scale_info::TypeInfo;
+use scale_info::prelude::boxed::Box;


I am wondering if scale_info::prelude::boxed::Box is different from sp_std::boxed::Box

pallets/voting/src/lib.rs

ilhanu

Looks good, nice work!

ilhanu · 2022-08-16T10:13:22Z

pallets/voting/README.md

@@ -0,0 +1 @@
+License: Unlicense


License Apache 2.0 or remove

ilhanu · 2022-08-16T10:16:47Z

pallets/voting/src/lib.rs

+		/// A investor has voted
+		InvestorVoted(T::AccountId, T::Hash, BlockNumberOf<T>),
+		/// TODO: to remove, Event for test purpose
+		CollectiveMotionChecked(BlockNumberOf<T>),


Think these events can be formed for the purpose of investor voting instead of removing them

ilhanu · 2022-08-16T10:29:14Z

pallets/voting/src/lib.rs

+	}
+
+	// Errors inform users that something went wrong.
+	#[pallet::error]


What about errors for the investor voting ?

the voting bring up the democracy's errors for the investor voting

ilhanu · 2022-08-16T10:37:15Z

pallets/voting/src/lib.rs

+			let block_number = <frame_system::Pallet<T>>::block_number();
+			let democration_motion_duration = block_number.saturating_add(<T as DEMO::Config>::VotingPeriod::get()).saturating_add(delay);
+
+			// Set the the storage to be wathed for the democracy process


Suggested change

// Set the the storage to be wathed for the democracy process

// Set the the storage to be watched for the democracy process

Man, hawkeye... Corrected!

* Updating branch with main updates (Fair-Squares#100) * Runtime update Update to polkadot-v0.9.26 * Token symbol and pallet-uniques Added the pallet-uniques to the runtime, and changed the token Symbol to USD * Benchmarking fixed Co-authored-by: ndkazu <ndongmefane@gmail.com> Co-authored-by: Kazunobu Ndong <33208377+ndkazu@users.noreply.github.com> * Merge main into voting pallet branch (Fair-Squares#104) * Runtime update Update to polkadot-v0.9.26 * Token symbol and pallet-uniques Added the pallet-uniques to the runtime, and changed the token Symbol to USD * Benchmarking fixed * refresh FS repo (Fair-Squares#101) * update readme and badges * delete diagram * add w3f badge and adjust readme * adjust size and position * remove unused files * adjusted the readme some more * add w3f badge back * changed from docker hub to ghcr registry * small change to the DockerFile * 102 automatization tasks (Fair-Squares#103) * added a script to add a new pallet from a pallet template and configure the runtime Cargo.toml and lib.rs * added a script to update polkadot lib in .toml files for the node, runtime, pallets and pallet template Co-authored-by: ndkazu <ndongmefane@gmail.com> Co-authored-by: Kazunobu Ndong <33208377+ndkazu@users.noreply.github.com> Co-authored-by: Ilhan <29432367+ilhanu@users.noreply.github.com> Co-authored-by: “ilhanu” <ilhanunlu@gmail.com> * added voting pallet, added config in runtime * added collective and democracy pallets to voting pallet and runtime config * added collective and democracy config to runtime * updated pallet_template * added members to house council * added functions to voting * added pallet roles to voting * update functions implementation * added events, refactored code * updated test configuration * added call formating for collective::propose() * added full process voting implementation with basic checks * added origin check on proposal dispatching from Democracy * added check origin call from collective pallet * added proposal status transition management and documentation * updated voting mockup for tests * refactored code * removed comments * code review updates * code review updates * fix for voting benchmarking * added fix for voting benchmarking * fix update * temporary deactivated voting benchmarking Co-authored-by: ndkazu <ndongmefane@gmail.com> Co-authored-by: Kazunobu Ndong <33208377+ndkazu@users.noreply.github.com> Co-authored-by: Ilhan <29432367+ilhanu@users.noreply.github.com> Co-authored-by: “ilhanu” <ilhanunlu@gmail.com>

letodunc and others added 17 commits July 18, 2022 13:31

added voting pallet, added config in runtime

9c557f0

added collective and democracy pallets to voting pallet and runtime c…

ab3e623

…onfig

added collective and democracy config to runtime

b492d99

updated pallet_template

2f9f9be

added members to house council

42194c7

added functions to voting

2aa0e1d

added pallet roles to voting

1cb16a3

update functions implementation

7ad0a04

added events, refactored code

19d04b1

updated test configuration

65634d3

added call formating for collective::propose()

03ebaa6

added full process voting implementation with basic checks

c5f71d5

added origin check on proposal dispatching from Democracy

30fdb0a

added check origin call from collective pallet

6baf939

added proposal status transition management and documentation

a995d56

letodunc added the enhancement New feature or request label Aug 16, 2022

letodunc added this to the M2 milestone Aug 16, 2022

letodunc requested review from ilhanu and ndkazu August 16, 2022 05:11

letodunc self-assigned this Aug 16, 2022

letodunc linked an issue Aug 16, 2022 that may be closed by this pull request

Voting Pallet #98

Closed

5 tasks

letodunc and others added 3 commits August 16, 2022 07:19

Merge branch 'main' into 98-voting-pallet

2f51df6

updated voting mockup for tests

4c1f726

Merge branch '98-voting-pallet' of https://github.com/Fair-Squares/fa…

2d70c77

…ir-squares into 98-voting-pallet

letodunc added 2 commits August 16, 2022 09:10

refactored code

0d44d24

removed comments

4a59015

ndkazu reviewed Aug 16, 2022

View reviewed changes

code review updates

ef0d525

ilhanu approved these changes Aug 16, 2022

View reviewed changes

letodunc added 5 commits August 16, 2022 13:40

code review updates

0b3cbb6

fix for voting benchmarking

ee82453

added fix for voting benchmarking

827df24

fix update

74db7c9

temporary deactivated voting benchmarking

cef7e62

ndkazu approved these changes Aug 16, 2022

View reviewed changes

letodunc merged commit aeffcca into main Aug 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

98 voting pallet #107

98 voting pallet #107

letodunc commented Aug 16, 2022

codecov-commenter commented Aug 16, 2022 •

edited

Loading

ndkazu left a comment

ndkazu Aug 16, 2022

ndkazu Aug 16, 2022

ilhanu left a comment

ilhanu Aug 16, 2022

ilhanu Aug 16, 2022

ilhanu Aug 16, 2022

letodunc Aug 16, 2022

ilhanu Aug 16, 2022

letodunc Aug 16, 2022

	// Set the the storage to be wathed for the democracy process
	// Set the the storage to be watched for the democracy process

98 voting pallet #107

98 voting pallet #107

Conversation

letodunc commented Aug 16, 2022

codecov-commenter commented Aug 16, 2022 • edited Loading

Codecov Report

ndkazu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ilhanu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Aug 16, 2022 •

edited

Loading