Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

137 onboarding pallet get houses with onboarded status #138

Merged
merged 3 commits into from
Sep 11, 2022

Conversation

letodunc
Copy link
Contributor

A new function has been added and exposed in the Onboarding pallet.
It allows the Bidding pallet to retrieve asset with onboarded status without using the acual storage getter houses() that requires arguments to get data.
We should have needed to call houses() with some arguments before filtering the assets by status. Here a call to get_onboaded_houses() gives directly assets with onboarded status.
The tests has been updated accordingly.

@letodunc letodunc added the enhancement New feature or request label Sep 10, 2022
@letodunc letodunc added this to the M3 milestone Sep 10, 2022
@letodunc letodunc requested review from ilhanu and ndkazu September 10, 2022 17:22
@letodunc letodunc self-assigned this Sep 10, 2022
@letodunc letodunc linked an issue Sep 10, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #138 (b624fc0) into main (1ac6d20) will increase coverage by 1.05%.
The diff coverage is 97.01%.

@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
+ Coverage   69.32%   70.38%   +1.05%     
==========================================
  Files          41       41              
  Lines        3097     3211     +114     
==========================================
+ Hits         2147     2260     +113     
- Misses        950      951       +1     
Impacted Files Coverage Δ
pallets/housing_fund/src/mock.rs 100.00% <ø> (ø)
pallets/onboarding/src/mock.rs 81.25% <0.00%> (-5.42%) ⬇️
pallets/onboarding/src/lib.rs 78.14% <85.00%> (+0.58%) ⬆️
pallets/housing_fund/src/functions.rs 95.00% <100.00%> (+0.88%) ⬆️
pallets/housing_fund/src/lib.rs 92.36% <100.00%> (ø)
pallets/housing_fund/src/structs.rs 100.00% <100.00%> (ø)
pallets/housing_fund/src/tests.rs 100.00% <100.00%> (ø)
pallets/onboarding/src/functions.rs 87.50% <100.00%> (+0.65%) ⬆️
pallets/onboarding/src/tests.rs 100.00% <100.00%> (ø)
pallets/onboarding/src/types.rs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ilhanu ilhanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ndkazu ndkazu merged commit bacdad7 into main Sep 11, 2022
cuteolaf pushed a commit to cuteolaf/fair-squares that referenced this pull request Oct 7, 2022
…pallet-get-houses-with-onboarded-status

137 onboarding pallet get houses with onboarded status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Onboarding pallet - Get houses with onboarded status
4 participants