Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review & refactor pallet-roles #153

Merged
merged 2 commits into from
Sep 24, 2022

Conversation

cuteolaf
Copy link
Member

No description provided.

@cuteolaf cuteolaf changed the title refactor: pallet-roles review & refactor pallet-roles Sep 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #153 (d732d48) into main (dc6b6de) will decrease coverage by 0.18%.
The diff coverage is 86.36%.

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
- Coverage   72.51%   72.32%   -0.19%     
==========================================
  Files          45       45              
  Lines        3300     3292       -8     
==========================================
- Hits         2393     2381      -12     
- Misses        907      911       +4     
Impacted Files Coverage Δ
pallets/roles/src/functions.rs 90.00% <76.92%> (-6.16%) ⬇️
pallets/roles/src/lib.rs 78.26% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@ndkazu ndkazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Clean up of the pallet_roles!!

@cuteolaf cuteolaf added the enhancement New feature or request label Sep 23, 2022
@cuteolaf cuteolaf self-assigned this Sep 23, 2022
@ndkazu ndkazu merged commit 5f5ca13 into Fair-Squares:main Sep 24, 2022
cuteolaf pushed a commit to cuteolaf/fair-squares that referenced this pull request Oct 7, 2022
…let_roles

review & refactor pallet-roles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants