Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review & refactor pallet_housing_fund #154

Merged

Conversation

cuteolaf
Copy link
Member

No description provided.

@cuteolaf cuteolaf changed the title use utility function fund_account_id instead of hard coding review & refactor pallet_housing_fund Sep 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #154 (5124acd) into main (5b8f2bd) will increase coverage by 1.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   71.25%   72.51%   +1.26%     
==========================================
  Files          45       45              
  Lines        3280     3300      +20     
==========================================
+ Hits         2337     2393      +56     
+ Misses        943      907      -36     
Impacted Files Coverage Δ
pallets/housing_fund/src/lib.rs 92.78% <100.00%> (ø)
pallets/onboarding/src/functions.rs 86.48% <0.00%> (-1.02%) ⬇️
pallets/nft/src/lib.rs 75.71% <0.00%> (-0.68%) ⬇️
pallets/nft/src/mock.rs 95.23% <0.00%> (-0.42%) ⬇️
pallets/nft/src/tests.rs 100.00% <0.00%> (ø)
pallets/share_distributor/src/tests.rs 100.00% <0.00%> (ø)
pallets/share_distributor/src/types.rs 100.00% <0.00%> (ø)
pallets/share_distributor/src/functions.rs 100.00% <0.00%> (ø)
runtime/src/lib.rs 7.40% <0.00%> (+0.04%) ⬆️
pallets/share_distributor/src/lib.rs 95.00% <0.00%> (+3.33%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@letodunc letodunc self-requested a review September 18, 2022 20:22
@letodunc letodunc added the enhancement New feature or request label Sep 18, 2022
@letodunc letodunc merged commit 02399cb into Fair-Squares:main Sep 18, 2022
cuteolaf added a commit to cuteolaf/fair-squares that referenced this pull request Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants