Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated tests, removed template tests, removed benchmarks #161

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

letodunc
Copy link
Contributor

Removed template tests
Updated tests for Bidding functionalities
Deactivated benchmark as no function in callable for the moment

@letodunc letodunc added the enhancement New feature or request label Sep 22, 2022
@letodunc letodunc added this to the M3 milestone Sep 22, 2022
@letodunc letodunc requested review from ilhanu and ndkazu September 22, 2022 18:50
@letodunc letodunc self-assigned this Sep 22, 2022
@letodunc letodunc linked an issue Sep 22, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #161 (10d9d52) into main (f028948) will increase coverage by 4.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   70.58%   74.86%   +4.27%     
==========================================
  Files          49       49              
  Lines        3424     3756     +332     
==========================================
+ Hits         2417     2812     +395     
+ Misses       1007      944      -63     
Impacted Files Coverage Δ
pallets/bidding/src/mock.rs 78.57% <ø> (+7.14%) ⬆️
runtime/src/lib.rs 7.40% <ø> (ø)
pallets/bidding/src/lib.rs 75.00% <100.00%> (+64.21%) ⬆️
pallets/bidding/src/tests.rs 100.00% <100.00%> (ø)
pallets/share_distributor/src/functions.rs 89.18% <0.00%> (-10.82%) ⬇️
pallets/share_distributor/src/lib.rs 90.62% <0.00%> (-4.38%) ⬇️
pallets/share_distributor/src/tests.rs 100.00% <0.00%> (ø)
pallets/share_distributor/src/types.rs 100.00% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@ndkazu ndkazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the next step for Pallet Bidding?

@letodunc
Copy link
Contributor Author

What is the next step for Pallet Bidding?

Improving the investor list creation.

@letodunc letodunc merged commit ec009b7 into main Sep 23, 2022
cuteolaf pushed a commit to cuteolaf/fair-squares that referenced this pull request Oct 7, 2022
…es#161)

* updated tests, removed template tests, removed benchmarks

* removed unused code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Bidding pallet - Tests implementation
3 participants