Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nft metadata modifications #165

Conversation

ndkazu
Copy link
Contributor

@ndkazu ndkazu commented Sep 24, 2022

Motivations
In the Onboarding Pallet, the Seller could only modify the price of the asset before submission to the council.
Now he can also change the asset metadata.

Execution

  • The helper_function set_metadata(owner: T::AccountId, collection_id: T::NftCollectionId, item_id: T::NftItemId, metadata: BoundedVecOfUnq<T>, )
    was added to the nft pallet. This helper function is actually using the pallet_uniques set_metadata.
  • In the pallet_onboarding, the user can change the initial metadata through the dispatchable function submit_awaiting(...).
  • Tests in onboarding were also updated

@ndkazu ndkazu added the enhancement New feature or request label Sep 24, 2022
@ndkazu ndkazu added this to the M3 milestone Sep 24, 2022
@ndkazu ndkazu requested review from ilhanu and letodunc September 24, 2022 09:38
@ndkazu ndkazu self-assigned this Sep 24, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #165 (38e37d0) into main (5f5ca13) will increase coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   74.63%   74.85%   +0.22%     
==========================================
  Files          49       49              
  Lines        3745     3766      +21     
==========================================
+ Hits         2795     2819      +24     
+ Misses        950      947       -3     
Impacted Files Coverage Δ
pallets/nft/src/functions.rs 69.23% <100.00%> (+6.59%) ⬆️
pallets/onboarding/src/functions.rs 87.83% <100.00%> (+1.35%) ⬆️
pallets/onboarding/src/lib.rs 88.98% <100.00%> (+0.29%) ⬆️
pallets/onboarding/src/tests.rs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ndkazu ndkazu merged commit 4b4c196 into main Sep 26, 2022
cuteolaf pushed a commit to cuteolaf/fair-squares that referenced this pull request Oct 7, 2022
…sset-distributor-pallet-fungible-+-config-shares-that-get-minted

Nft metadata modifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants