Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an event to dispatch #177

Conversation

ndkazu
Copy link
Contributor

@ndkazu ndkazu commented Sep 28, 2022

  • In pallet_roles/set_manager dispatch, do not check that new and old manager are different accounts
  • Ads an event to the pallet_onboarding/change_status dispatch function

Motivation

  • Pallet roles
  1. The sudo pallet_key cannot be attributed to more than one account
  2. By Default, Alice has the sudo_key, but has no role.
    The sudo key should have the authority to attribute a role to himself. the set_role dispatch will only work if no role is attributed yet. The check implemented previously only prevent the sudo key to get a role during the Genesis stage of the pallet
  • Pallet Onboarding
    An event makes it easier to track the status change, and see clearly if the corresponding calls are executed or not.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@d26f1b6). Click here to learn what that means.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage        ?   76.76%           
=======================================
  Files           ?       49           
  Lines           ?     4119           
  Branches        ?        0           
=======================================
  Hits            ?     3162           
  Misses          ?      957           
  Partials        ?        0           
Impacted Files Coverage Δ
pallets/roles/src/lib.rs 78.02% <ø> (ø)
pallets/onboarding/src/lib.rs 88.79% <83.33%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ndkazu ndkazu requested review from ilhanu and letodunc September 28, 2022 22:50
Copy link
Member

@ilhanu ilhanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Fix, and the event is very good to have.
🚀

@ndkazu ndkazu merged commit 3180e27 into main Sep 29, 2022
cuteolaf pushed a commit to cuteolaf/fair-squares that referenced this pull request Oct 7, 2022
…sset-distributor-pallet-fungible-+-config-shares-that-get-minted

Added an event to  dispatch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants