176 bidding pallet intergrate share distributor pallet #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndkazu
reviewed
Sep 29, 2022
No, but the change wasn't onboarded in the commit. Now you should see it. |
ilhanu
reviewed
Sep 29, 2022
Codecov Report
@@ Coverage Diff @@
## main #178 +/- ##
==========================================
+ Coverage 76.81% 78.16% +1.34%
==========================================
Files 49 49
Lines 4124 4378 +254
==========================================
+ Hits 3168 3422 +254
Misses 956 956
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ndkazu
approved these changes
Sep 30, 2022
cuteolaf
pushed a commit
to cuteolaf/fair-squares
that referenced
this pull request
Oct 7, 2022
) * updated tests with the call periodicity of process_onboarded_asset() * added process_finalised_asset, updated tests * added unreservation of reserved funds in Housing fund * added share distributor pallet in bidding pallet * updated test setup * added functions in housing fund, updated tests * added unreserved fund in Housing fund for asset transfer * updated tests in share distributor * added call to share distributor in bidding pallet * updated investor list creation conditions * added omitted updates * added spelling fix and renaming additional Commits in this PR. * added event on house status change in Onboarding pallet * added bypass filter on dispatch calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call share distributor from bidding pallet
Added complementary functions in housing fund to manage unreservation fund and purchase operation
Updated
Onboarding::do_buy()with housing fund to manage fund unreserved for the purchase inHousing FundUpdated
Share_Distributor::create_virtual()with housing fund purchase process to keep transaction history and stay up to dateUpdated tests to cover the updates