Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review & refactor: pallet-voting #184

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

cuteolaf
Copy link
Member

@cuteolaf cuteolaf commented Oct 6, 2022

No description provided.

@cuteolaf cuteolaf requested review from ilhanu and ndkazu and removed request for ilhanu October 6, 2022 02:06
@cuteolaf cuteolaf force-pushed the cuteolaf/review/pallet_voting branch from 762b1d4 to 6bc3550 Compare October 6, 2022 02:14
@cuteolaf cuteolaf marked this pull request as draft October 6, 2022 02:27
@cuteolaf cuteolaf removed the request for review from ndkazu October 6, 2022 02:27
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Merging #184 (6bc3550) into main (bcfc3b9) will decrease coverage by 0.01%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
- Coverage   78.04%   78.03%   -0.02%     
==========================================
  Files          49       49              
  Lines        4378     4380       +2     
==========================================
+ Hits         3417     3418       +1     
- Misses        961      962       +1     
Impacted Files Coverage Δ
pallets/voting/src/lib.rs 79.34% <72.72%> (-0.28%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cuteolaf cuteolaf changed the title refactor: use get_origin instead of hard coding review & refactor: pallet-voting Oct 6, 2022
@cuteolaf cuteolaf marked this pull request as ready for review October 17, 2022 16:01
@letodunc letodunc merged commit 5ac0058 into Fair-Squares:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants