Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

201 representative role approval #202

Merged
merged 5 commits into from
Nov 14, 2022
Merged

Conversation

ndkazu
Copy link
Contributor

@ndkazu ndkazu commented Nov 14, 2022

Motivation
This task concern the asset_management pallet:

  • Make the approval call that will be used by the voting system

  • write the approval call testing

@ndkazu ndkazu linked an issue Nov 14, 2022 that may be closed by this pull request
2 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #202 (ddce734) into main (471e031) will decrease coverage by 0.28%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   78.89%   78.60%   -0.29%     
==========================================
  Files          50       51       +1     
  Lines        4388     4394       +6     
==========================================
- Hits         3462     3454       -8     
- Misses        926      940      +14     
Impacted Files Coverage Δ
pallets/asset_management/src/functions.rs 0.00% <0.00%> (ø)
pallets/asset_management/src/lib.rs 0.00% <0.00%> (ø)
pallets/roles/src/lib.rs 72.17% <ø> (-1.97%) ⬇️
pallets/roles/src/functions.rs 93.61% <100.00%> (+2.80%) ⬆️
pallets/roles/src/tests.rs 100.00% <100.00%> (ø)
pallets/roles/src/types.rs 94.00% <100.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@letodunc letodunc self-requested a review November 14, 2022 13:09
@ndkazu ndkazu requested review from cuteolaf and ilhanu November 14, 2022 13:09
@letodunc letodunc merged commit 2f286bc into main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Representative role Approval
4 participants