refactor: pallet-bidding

[cuteolaf]

No description provided.

[cuteolaf]

@ilhanu @ndkazu
please review & merge this PR asap

[ndkazu]

Looks good, did you try testing the workflow using polkadot.js to see if everything is still working as expected?

[codecov-commenter]

Codecov Report

Merging #203 (9ad7be4) into main (471e031) will decrease coverage by 0.21%.
The diff coverage is 82.02%.

@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
- Coverage   78.89%   78.68%   -0.22%     
==========================================
  Files          50       50              
  Lines        4388     4377      -11     
==========================================
- Hits         3462     3444      -18     
- Misses        926      933       +7     

Impacted Files	Coverage Δ
pallets/bidding/src/lib.rs	70.00% <74.19%> (-3.96%)	⬇️
pallets/housing_fund/src/functions.rs	86.23% <100.00%> (-0.49%)	⬇️
pallets/onboarding/src/functions.rs	84.21% <100.00%> (-0.41%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[ilhanu]

It looks good, just note cargo-fmt might change all the formatting you have done.
Also can you implement cargo clippy