210 add finalization pallet #214
Conversation
Codecov Report
@@ Coverage Diff @@
## main #214 +/- ##
==========================================
+ Coverage 79.61% 81.19% +1.58%
==========================================
Files 53 57 +4
Lines 4571 5047 +476
==========================================
+ Hits 3639 4098 +459
- Misses 932 949 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -21,6 +21,7 @@ pub enum AssetStatus { | |||
| PURCHASED, | |||
| REJECTED, | |||
| SLASH, | |||
| CANCELLED, | |||
There was a problem hiding this comment.
Great to have gotten Cancelled, it may be a bit undefined yet what we do with this status.
What happens to the deposit of the seller ? Since the seller was the one initiating and cancelling there should be a fee to pay. This isn't comment on the PR, just a feedback potential issue for the future.
There was a problem hiding this comment.
With Cancelled status, we know that the transaction didn't succeed not because of the notary but because of the seller. For the moment, cancelling is free, but later, a slash will be applied to the seller.
| } | ||
|
|
||
| #[test] | ||
| fn validate_transaction_asset_should_succeed() { |
There was a problem hiding this comment.
@letodunc you think we should extend this test till share-distributor?
There was a problem hiding this comment.
I think we can relay on the tests in the bidding pallet for the process_finalised_assets(). This is the step following the finalizer pallet execution.
Implemented pallet finalizer methods