Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization and code documentation #241

Merged
merged 2 commits into from
Feb 6, 2023
Merged

Optimization and code documentation #241

merged 2 commits into from
Feb 6, 2023

Conversation

ndkazu
Copy link
Contributor

@ndkazu ndkazu commented Feb 4, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #241 (71db366) into main (da729c5) will increase coverage by 0.99%.
The diff coverage is 99.38%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
+ Coverage   82.39%   83.38%   +0.99%     
==========================================
  Files          69       69              
  Lines        6851     7007     +156     
==========================================
+ Hits         5645     5843     +198     
+ Misses       1206     1164      -42     
Impacted Files Coverage Δ
pallets/asset_management/src/lib.rs 77.94% <ø> (ø)
pallets/asset_management/src/mock.rs 95.83% <ø> (ø)
pallets/payment/src/mock.rs 100.00% <ø> (+45.83%) ⬆️
pallets/tenancy/src/lib.rs 80.00% <ø> (ø)
pallets/tenancy/src/mock.rs 95.23% <ø> (ø)
runtime/src/lib.rs 10.28% <ø> (ø)
pallets/asset_management/src/functions.rs 91.35% <88.88%> (+0.16%) ⬆️
pallets/payment/src/tests.rs 99.52% <100.00%> (+0.15%) ⬆️
pallets/payment/src/lib.rs 77.16% <0.00%> (+1.57%) ⬆️
pallets/payment/src/weights.rs 11.11% <0.00%> (+11.11%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ndkazu ndkazu requested review from ilhanu and cuteolaf February 4, 2023 14:35
Copy link
Member

@ilhanu ilhanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra testing! Looks A+

@ndkazu ndkazu merged commit edba4c1 into main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants