Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset representative #253

Merged
merged 7 commits into from
Feb 25, 2023
Merged

Asset representative #253

merged 7 commits into from
Feb 25, 2023

Conversation

cuteolaf
Copy link
Member

@cuteolaf cuteolaf commented Feb 24, 2023

  • Added representative field in the asset struct
  • Added more checks for launch_representative_session
  • Updated the functions and tests accordingly

@cuteolaf cuteolaf requested a review from letodunc February 24, 2023 20:35
Copy link
Contributor

@ndkazu ndkazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tenant_session error is not right.

pallets/asset_management/src/lib.rs Show resolved Hide resolved
pallets/asset_management/src/tests.rs Outdated Show resolved Hide resolved
pallets/asset_management/src/tests.rs Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #253 (21cedd6) into main (167b087) will decrease coverage by 0.04%.
The diff coverage is 84.61%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
- Coverage   83.09%   83.06%   -0.04%     
==========================================
  Files          69       69              
  Lines        6993     7019      +26     
==========================================
+ Hits         5811     5830      +19     
- Misses       1182     1189       +7     
Impacted Files Coverage Δ
pallets/asset_management/src/mock.rs 88.88% <ø> (ø)
pallets/onboarding/src/types.rs 100.00% <ø> (ø)
pallets/roles/src/functions.rs 90.29% <50.00%> (-0.75%) ⬇️
pallets/asset_management/src/lib.rs 77.97% <79.06%> (+0.14%) ⬆️
pallets/asset_management/src/functions.rs 89.45% <92.00%> (+0.79%) ⬆️
pallets/asset_management/src/tests.rs 99.66% <100.00%> (+<0.01%) ⬆️
pallets/onboarding/src/tests.rs 100.00% <100.00%> (ø)
node/src/chain_spec.rs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cuteolaf cuteolaf merged commit 94d908e into main Feb 25, 2023
@cuteolaf cuteolaf deleted the asset-representative branch February 25, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants