-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Mac CI nodes #517
base: dev
Are you sure you want to change the base?
Update Mac CI nodes #517
Conversation
📝 WalkthroughWalkthroughThe changes in this pull request focus on the Changes
Sequence Diagram(s)sequenceDiagram
participant Jenkins as Jenkins
participant JobMatrix as JobMatrix Function
participant macOS as macOS Builds
Jenkins->>JobMatrix: Request build configurations
JobMatrix->>macOS: Fetch current configurations
macOS-->>JobMatrix: Provide updated configurations
JobMatrix->>Jenkins: Return configurations
Jenkins->>macOS: Execute build with updated configurations
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
Jenkinsfile (1)
99-101
: Confirm the intentional removal of macOS 13 supportI notice that macOS 13 support has been removed. While upgrading to newer versions is good practice, please confirm:
- This removal is intentional and communicated to users
- There are no critical workflows depending on macOS 13
Consider:
- Adding a deprecation notice in the release notes
- Documenting the minimum supported macOS version in the README
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
Jenkinsfile
(1 hunks)
🔇 Additional comments (2)
Jenkinsfile (2)
99-101
: Verify CI infrastructure readiness for the new configurations
The changes look good from a configuration perspective, but please ensure:
- CI nodes for macOS 15 (both x86_64 and arm64) are properly set up and available
- apple-clang-16 is installed and configured on all macOS nodes (14 and 15)
101-101
: Verify arm64 build requirements
The addition of arm64 architecture support for macOS 15 is good for native Apple Silicon support. Please ensure:
- All required dependencies support arm64 architecture
- CI runners with arm64 architecture are available and properly configured
No description provided.