Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove org-global context from the build. Update codeowners #126

Merged
merged 4 commits into from
Mar 6, 2020

Conversation

sudermanjr
Copy link
Member

@sudermanjr sudermanjr commented Mar 6, 2020

Also fix #125

@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #126 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   43.39%   43.39%           
=======================================
  Files           8        8           
  Lines         553      553           
=======================================
  Hits          240      240           
  Misses        302      302           
  Partials       11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e635d2a...25a14ed. Read the comment docs.

@sudermanjr sudermanjr requested a review from lucasreed March 6, 2020 16:23
@sudermanjr sudermanjr changed the title remove org-global context from the build step since it doesn't need creds anymore remove org-global context from the build. Update codeowners Mar 6, 2020
@sudermanjr sudermanjr merged commit 54b3a21 into master Mar 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the sudermanjr/fix-authorization branch March 6, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix README.md for helm install
2 participants