Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update client go and vpa #203

Merged
merged 9 commits into from
Aug 24, 2020
Merged

Update client go and vpa #203

merged 9 commits into from
Aug 24, 2020

Conversation

sudermanjr
Copy link
Member

@sudermanjr sudermanjr commented Aug 17, 2020 •
edited
Loading

  • Support all auth methods
  • Client-go v0.18.6
  • VPA is now autoscaling v1 apiVersion
  • Updated demo chart in e2e tests

Fixes #197

@sudermanjr sudermanjr requested a review from lucasreed as a code owner August 17, 2020 17:23
@sudermanjr sudermanjr requested a review from rbren August 17, 2020 17:58
@sudermanjr sudermanjr mentioned this pull request Aug 17, 2020
Merged
@codecov
Copy link

codecov bot commented Aug 17, 2020 •
edited
Loading

Codecov Report

Merging #203 into master will decrease coverage by 0.07%.
The diff coverage is 77.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
- Coverage   51.65%   51.57%   -0.08%     
==========================================
  Files           8        8              
  Lines         606      605       -1     
==========================================
- Hits          313      312       -1     
  Misses        261      261              
  Partials       32       32
Impacted Files Coverage Δ
pkg/controller/controller.go 6.55% <0.00%> (ø)
pkg/utils/utils.go 100.00% <ø> (ø)
pkg/summary/summary.go 46.66% <75.00%> (ø)
pkg/vpa/vpa.go 71.64% <90.90%> (-0.15%) ⬇️
pkg/kube/client.go 17.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d885622...aaa2ff8. Read the comment docs.

lucasreed
lucasreed approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@lucasreed lucasreed left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one inline question. I trust most of the changes because of the passing e2e tests.

go.mod Outdated Show resolved Hide resolved
@sudermanjr sudermanjr merged commit 159ff4a into master Aug 24, 2020
hjkatz added a commit to hjkatz/goldilocks that referenced this pull request Aug 24, 2020
@hjkatz
Merge pull request #15 from FairwindsOps/master
4d2b37b 
Update client go and vpa (FairwindsOps#203)
@sudermanjr sudermanjr deleted the sudermanjr/updates branch September 6, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasreed lucasreed lucasreed approved these changes

@rbren rbren Awaiting requested review from rbren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update client-go and associated tools to 0.18.x
2 participants
@sudermanjr @lucasreed