-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve navigation accessibility and usability #544
Merged
sudermanjr
merged 34 commits into
FairwindsOps:master
from
thewildmage:thewildmage/improve-navigation
Oct 31, 2022
Merged
Improve navigation accessibility and usability #544
sudermanjr
merged 34 commits into
FairwindsOps:master
from
thewildmage:thewildmage/improve-navigation
Oct 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For improved clarity and to avoid tying design to naming
Is wired up and working, but doesn't feel like it because results update without using it
It's been folded into the filter template
Co-Authored-By: Andrew Suderman <andy@fairwinds.com>
Thanks for the PR, @thewildmage ! Excited to check out these changes. |
sudermanjr
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not address any specific open Issue.
Checklist
Description
What's the goal of this PR?
To improve the usability and accessibility of the inter- and intra-page navigation.
What changes did you make?
What alternative solution should we consider, if any?
These changes were largely informed by:
slides
repoI believe based on this research that I've provided a solid solution, but there may be other possible approaches.
I've also tested these changes on MacOS with Firefox, Safari, and Brave (which is Chromium-based) using VoiceOver.