Change the behavior of burstable QoS class icons and text #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fairwinds Insights CI Report✅ 1 Action Items have been fixed! 🎉 Fixed Action Itemsus-docker.pkg.dev/fairwinds-ops/oss/goldilocks
|
transient1
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #316
Checklist
Description
What's the goal of this PR?
Equals now means equals exactly, not "inside range"
What changes did you make?
Updated logic
What alternative solution should we consider, if any?
We should consider some rounding, as well as some percentage difference at which we recommend a change.