Allow disabling the cost functionality #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fairwinds Insights CI Report✅ No new Action Items detected! |
transient1
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #630
Checklist
Description
What's the goal of this PR?
Allow users of the dashboard to disable the cost functionality with
--enable-costs=falseWhat changes did you make?
Add the flag and pass it into the dashboard. Disable the templates and scripts for cost functionality if that flag is disabled.
In order to do this, I refactored a little bit of the code that passes options to the dashboard, and started passing the entire options struct into the template.
What alternative solution should we consider, if any?
n/a