Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues detecting on Ingress #71

Closed
stefansedich opened this issue May 1, 2020 · 7 comments · Fixed by #72
Closed

Issues detecting on Ingress #71

stefansedich opened this issue May 1, 2020 · 7 comments · Fixed by #72
Assignees

Comments

@stefansedich
Copy link

stefansedich commented May 1, 2020

Trying to detect on an ingress object:

cat << EOF | pluto detect - -v=10
apiVersion: networking.k8s.io/v1beta1
kind: Ingress
EOF

And I see the following error and response:

I0501 10:38:38.954095 1267123 versions.go:98] invalid json: invalid character 'a' looking for beginning of value
There were no apiVersions found that match our records.
I0501 10:38:38.954169 1267123 root.go:209] retCode: 0

However works fine on a Deployment:

cat << EOF | pluto detect -      
apiVersion: apps/v1beta1             
kind: Deployment
EOF      

NAME   KIND         VERSION        REPLACEMENT   REMOVED   DEPRECATED  
       Deployment   apps/v1beta1   apps/v1       true      true 

Is this expected? am I holding it wrong? or is it a bug?

@sudermanjr
Copy link
Member

Looks like maybe we don't have that version listed networking.k8s.io/v1beta1. I'll take a look

@sudermanjr sudermanjr self-assigned this May 1, 2020
@sudermanjr
Copy link
Member

sudermanjr commented May 1, 2020

From this list - https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/

It looks like the old version was extensions/v1beta1, not networking.k8s.io/v1beta1

Am I missing something?

kubectl api-versions on a 1.16 cluster lists networking.k8s.io/v1beta1 as a valid version still. Not sure if it is planned for deprecation yet

@vladlosev
Copy link

Ingresses in extensions/v1beta1 do not seem to be detected, either:

(base) ip-192-168-1-56:~ vladimir.losev$ cat <<EOF | pluto detect -
apiVersion: extensions/v1beta1
kind: Ingress
EOF
There were no apiVersions found that match our records.

@stefansedich
Copy link
Author

stefansedich commented May 1, 2020

No luck either with --show-all however for an apps/v1 deployment it works fine even though it is not deprecated, I would expect the same for Ingress?

cat << EOF | pluto detect --show-all -
apiVersion: apps/v1
kind: Deployment
EOF

NAME   KIND         VERSION   REPLACEMENT   REMOVED   DEPRECATED  
       Deployment   apps/v1                 false     false   

@sudermanjr
Copy link
Member

Looks like we missed that version. @stefansedich #72 should fix.

@stefansedich
Copy link
Author

Looks like we missed that version. @stefansedich #72 should fix.

🎉 thanks!

@vladlosev
Copy link

Nice! Impressively quick fix! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants