Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ingresses in extensions/v1beta1 to versions list #72

Merged
merged 2 commits into from
May 1, 2020
Merged

Add ingresses in extensions/v1beta1 to versions list #72

merged 2 commits into from
May 1, 2020

Conversation

sudermanjr
Copy link
Member

Fixes #71

@sudermanjr sudermanjr requested a review from lucasreed as a code owner May 1, 2020 18:03
@sudermanjr sudermanjr mentioned this pull request May 1, 2020
Closed
lucasreed
lucasreed suggested changes May 1, 2020
View reviewed changes
pkg/api/list.go Outdated
@@ -39,6 +39,7 @@ var VersionList = []Version{
{"apps/v1beta2", "StatefulSet", "v1.9.0", "v1.16.0", "apps/v1"},

{"extensions/v1beta1", "NetworkPolicy", "v1.9.0", "v1.16.0", "networking.k8s.io/v1"},
{"extensions/v1beta1", "Ingress", "v1.9.0", "v1.16.0", "networking.k8s.io/v1beta1"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was deprecated in v1.14.0 and will be removed in v1.22.0. It is confusingly put in the same article as the 1.16 removals, but does specify those versions: https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch. Fixed.

@sudermanjr sudermanjr requested a review from lucasreed May 1, 2020 18:08
lucasreed
lucasreed approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@lucasreed lucasreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented May 1, 2020 •
edited
Loading

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   77.90%   77.90%           
=======================================
  Files           6        6           
  Lines         353      353           
=======================================
  Hits          275      275           
  Misses         51       51           
  Partials       27       27
Impacted Files Coverage Δ
pkg/api/list.go 77.27% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b1de39...49c1e9a. Read the comment docs.

@sudermanjr sudermanjr merged commit 25c70cb into master May 1, 2020
@sudermanjr sudermanjr deleted the sudermanjr/fix-71-add-ingress-extensions branch May 1, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasreed lucasreed lucasreed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues detecting on Ingress
2 participants
@sudermanjr @lucasreed