fix : rules to load client configuration to connect to a kubernetes cluster #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hello @sudermanjr @transient1 Any news please ? Thanks in advance. Sophian |
|
Hello @sudermanjr @transient1 Any news please ? Thanks in advance. Sophian |
|
@smehboub can you please rebase your PR? |
sudermanjr
requested changes
Feb 6, 2023
smehboub
force-pushed
the
fix/issue-418
branch
from
fdb6093 to
e2faddd
Compare
Hello @sudermanjr Thanks you for feedbacks, It's done. Rgs, |
smehboub
force-pushed
the
fix/issue-418
branch
2 times, most recently
from
93f8063 to
9bbfea2
Compare
smehboub
force-pushed
the
fix/issue-418
branch
from
9bbfea2 to
19e0fbe
Compare
|
Hi, @smehboub . Just wanted to let you know I will be reviewing this PR over the next day or so. |
Thank you :-) |
aslafy-z
reviewed
Feb 9, 2023
smehboub
requested review from
aslafy-z and
sudermanjr
and removed request for
sudermanjr and
aslafy-z
transient1
approved these changes
Feb 10, 2023
Thank you too :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix : rules to load client configuration to connect to a kubernetes cluster
This PR :
Fixes #418
Checklist
Description
What's the goal of this PR?
The same rules to load client configuration for all commands that need to connect to a kubernetes cluster
What changes did you make?
Use the same way to load client configuration to connect to a kubernetes cluster as the detect-helm command for all commands
What alternative solution should we consider, if any?
None