Fix using REPL AVAIL/REPL AVAIL IN as custom columns #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two were not included in `possibleColumns` and therefore running e.g. `pluto detect-files -o markdown --columns "REPL AVAIL"` would not actually print the column, despite no error being reported.
|
Anything I can do about the Vault token error in CI? |
|
|
sudermanjr
approved these changes
Dec 18, 2023
|
I think we've had some recent issues with our CLA assistant, if you could sign that again please @valorl , we'll get that merged. |
|
signed 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two were not included in
possibleColumnsand therefore running e.g.pluto detect-files -o markdown --columns "REPL AVAIL"would not actually print the column, despite no error being reported.This PR fixes #514
Checklist
Description
What's the goal of this PR?
Fix the above issue
What changes did you make?
Added the two columns in the
possibleColumnssliceWhat alternative solution should we consider, if any?