Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for CI/CD use case #127

Merged
merged 2 commits into from
Jun 10, 2019
Merged

Better support for CI/CD use case #127

merged 2 commits into from
Jun 10, 2019

Conversation

rbren
Copy link
Contributor

@rbren rbren commented May 23, 2019

Goal here was better support for CI/CD, but it ended up being a bit of a rabbit hole.

A few notes:

  • Changed YAML marshaler to one that formats consistently with JSON marshaler
  • Added score to output
  • Added output-format which can be json, yaml, or score - the last option there just prints the overall score, e.g. 93
  • Changes to docs

@rbren rbren requested a review from robscott as a code owner May 23, 2019 17:26
Gopkg.toml Outdated Show resolved Hide resolved
@rbren rbren force-pushed the rb/ci-instructions branch 3 times, most recently from 5730832 to 5ebb2d3 Compare May 28, 2019 14:49
add score to output

add output-format option

update README with more use cases

change YAML marshal strategy

fix webhook install instructions
README.md Show resolved Hide resolved
@endzyme endzyme requested a review from kimschles as a code owner June 8, 2019 01:24
Copy link
Contributor

@endzyme endzyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I appreciate rolling that score logic into the summary struct. I am still coming up to speed but this looks 👍

@rbren rbren merged commit 7cfa13f into master Jun 10, 2019
@endzyme endzyme deleted the rb/ci-instructions branch June 10, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants