Add support for stateful sets #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbren
force-pushed
the
rb/more-controllers
branch
4 times, most recently
from
48fadb6
to
18fd427
Compare
robscott
approved these changes
Jun 12, 2019
rbren
force-pushed
the
rb/more-controllers
branch
from
18fd427
to
24e503d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lays the groundwork for adding other controller types as well.
There's sadly a lot of boilerplate that's going to be copied from controller to controller. Open to ideas on how to mitigate this.
Are there any checks we do that shouldn't apply to StatefulSets or other controllers?
Here's how it looks in the dash: