add deploy configurations to source control #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbren
force-pushed
the
rb/deploy
branch
7 times, most recently
from
aeecfb2
to
fb55385
Compare
endzyme
reviewed
Jun 28, 2019
endzyme
reviewed
Jun 28, 2019
endzyme
approved these changes
Jun 28, 2019
|
Note: the 10-15 minute breakage mentioned above has been solved. The README will continue to reference the deploy YAML on the releases page, which will always point to a valid Docker image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight hiccup with this process: the new deploy.yaml will get checked in before the images are built. So there will be a 10-15 minute period of breakage.
Maybe it'd be better to tag the commit before it gets merged - that way images are built ahead of time. And we can run goreleaser only once that tag is merged into master.
Thoughts?