Pod tests #177
Merged
Pod tests #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willfairwinds
requested review from
rbren,
endzyme,
kimschles and
robscott
as code owners
|
|
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
=========================================
+ Coverage 82.41% 84.12% +1.7%
=========================================
Files 9 9
Lines 529 529
=========================================
+ Hits 436 445 +9
+ Misses 68 65 -3
+ Partials 25 19 -6
Continue to review full report at Codecov.
|
|
Thanks for the submission @willfairwinds! We'll take a look this week but so far seems pretty straight forward. |
rbren
approved these changes
Jul 24, 2019
pkg/validator/pod_test.go
Outdated
|
|
||
| actualPodResult := ValidatePod(c, &pod.Spec) | ||
|
|
||
| assert.Equal(t, len(actualPodResult.ContainerResults), 1, "should be equal") |
There was a problem hiding this comment.
Expected and actual are flipped here (1 is the expected value). Same above and below
|
🎉 Looks good to me! CLA wants you to sign again for some reason, but once that's done you're good to merge. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added pod tests for configured Host IPC, Host PID, and Host Newtowrk, also fixed order of expected and actual results in the original test and all others.