Fix logic with service accounts. Update e2e tests. Add test coverage #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudermanjr
changed the title
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
+ Coverage 36.00% 41.01% +5.01%
==========================================
Files 4 4
Lines 175 178 +3
==========================================
+ Hits 63 73 +10
+ Misses 103 100 -3
+ Partials 9 5 -4
Continue to review full report at Codecov.
|
sudermanjr
changed the title
lucasreed
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug in the subjectKey logic in the lister where we would miss a lot of bindings that were related to service accounts. I have added test coverage and e2e tests to cover this.
Fixes #42