Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for kube 1.18 and client-go 1.18 #81

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Update for kube 1.18 and client-go 1.18 #81

merged 2 commits into from
Mar 30, 2020

Conversation

sudermanjr
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 30, 2020 •
edited
Loading

Codecov Report

Merging #81 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #81   +/-   ##
=======================================
  Coverage   39.19%   39.19%           
=======================================
  Files           4        4           
  Lines         199      199           
=======================================
  Hits           78       78           
  Misses        112      112           
  Partials        9        9
Impacted Files Coverage Δ
lookup/lister.go 54.08% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb5e89e...a5ff6d7. Read the comment docs.

lucasreed
lucasreed approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@lucasreed lucasreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, good find for the fix 👏

@sudermanjr sudermanjr merged commit a63dd75 into master Mar 30, 2020
@sudermanjr sudermanjr deleted the sudermanjr/v1.18 branch March 30, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasreed lucasreed lucasreed approved these changes

@kimschles kimschles Awaiting requested review from kimschles

@robscott robscott Awaiting requested review from robscott

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sudermanjr @lucasreed