[go] parse environment variables #505

lucasreed · 2022-01-03T19:36:17Z

Also changed in this PR:

make conversion from v1 to v2 schema a private function since everything should happen with the OpenV2 function.
changed all klog.Fatal() calls in the cmd package to red error output with exit code of 1 instead
reckoner convert command no longer calls the ConvertV1toV2 function and instead simply uses OpenV2 function.

…de 1 instead

lucasreed · 2022-01-03T19:38:41Z

pkg/course/course.go

+ // Marshal back here just so we can populate the env vars without any yaml comments present
+ data, _ = yaml.Marshal(courseFile)
+ data, err = parseEnv(data)
+ if err != nil {
+ return nil, fmt.Errorf("failed to parse env variables: %v", err)
+ }
+ err = yaml.Unmarshal(data, courseFile)
+ if err != nil {
+ return nil, fmt.Errorf("failed to unmarshal file after parsing env vars: %s", err.Error())
+ }
+


The reason we are doing this unmarshal -> marshal -> unmarshal again is because if we parsed environment variables before the first unmarshal, it would also error out on any YAML comments that mention an environment variable. When we do the first unmarshal, all comments are stripped so we can marshal back to bytes, populate all the env vars and then unmarshal into our struct again.