Don't parse env on convert command #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
lucasreed
approved these changes
Apr 22, 2022
There was a problem hiding this comment.
I can't think of a better way to do this either without introducing a new struct that is only for env parsing and even then I'm not 100% sure that would be pretty either.
It's really striking how much of this course package revolves around unmarshaling and environment variable parsing. I'm not sure there's a better way, but it still feels weird.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #577
Checklist
Description
What's the goal of this PR?
When running
reckoner convert, we shouldn't parse environment variablesWhat changes did you make?
Added a package variable to disable env parsing
What alternative solution should we consider, if any?
There's likely a cleaner way to do this, I'm not overly happy about using a global for this, but due to the extreme ways in which we have to have to handle yaml, this may be necessary